build,win: bail vcbuild if mklink fails#27216
Merged
refack merged 1 commit intonodejs:masterfrom Apr 20, 2019
Merged
Conversation
Collaborator
nodejs-github-bot
added
build
refack
force-pushed
the
bail-vcbuild-if-mklink-fails
branch
from
772c4db to
1a39749
Compare
refack
commented
Apr 13, 2019
Collaborator
richardlau
approved these changes
Apr 13, 2019
Collaborator
refack
force-pushed
the
bail-vcbuild-if-mklink-fails
branch
from
b09360b to
b72f24e
Compare
Collaborator
Contributor
Author
|
/CC @nodejs/build-files @nodejs/platform-windows |
refack
added
the
author ready
PR-URL: nodejs#27216 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack
force-pushed
the
bail-vcbuild-if-mklink-fails
branch
from
b72f24e to
0fc27f6
Compare
refack
removed
the
author ready
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #27149 (comment)
Otherwise vcbuild will continue even if
mklinkfails, and will use old artifacts if present.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes