test: fs internal util preprocessSymlinkDestination() function#27468
Closed
rpgeeganage wants to merge 1 commit intonodejs:masterfrom
Closed
test: fs internal util preprocessSymlinkDestination() function#27468rpgeeganage wants to merge 1 commit intonodejs:masterfrom
rpgeeganage wants to merge 1 commit intonodejs:masterfrom
Conversation
rpgeeganage
changed the title
addaleax
approved these changes
Apr 28, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I think you an even assert the exact return values of the function, instead of applying regexes here?
(Either way, this LGTM, and thank you!)
Collaborator
Trott
approved these changes
Apr 29, 2019
shisama
approved these changes
Apr 29, 2019
Collaborator
Contributor
Author
|
@addaleax, |
cjihrig
approved these changes
Apr 29, 2019
Member
|
@rpgeeganage Yeah, it’s not a blocking review comment that needs to be addressed in order for this to land. :) |
addaleax
added
the
author ready
Contributor
Author
|
@addaleax , |
Member
|
Landed in 64284aa |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 1, 2019
PR-URL: nodejs#27468 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 4, 2019
PR-URL: #27468 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests for
preprocessSymlinkDestination()function in'internal/fs/utils'.These tests are without any monkey-patching for the platform.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes