build: fix ARM vfp naming in configure script for older ARM processors#2751
build: fix ARM vfp naming in configure script for older ARM processors#2751mnkhouri wants to merge 1 commit intonodejs:masterfrom mnkhouri:vfp_for_older_arm
Conversation
|
To reproduce: My toolchain: |
|
/ @nodejs/build |
|
LGTM apart from the commit log: the first line should be <= 50 columns, ones after that <= 72.
|
This commit changes the default vfp name from 'vfpv2' to 'vfp', affecting builds for ARM architectures older than ARMv7. Valid options for 'arm_fpu' in gcc do NOT include 'vfpv2', causing gcc to quit with error: unrecognized argument in option ‘-mfpu=vfpv2’ when using the configure script with --dest-cpu=arm. Gyp also expects only vfp, vfpv3-d16, vfpv3, neon. GCC reference for the -mfpu= option: https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html Gyp makefile reference: https://github.com/nodejs/node/blob/v4.0.0/Makefile.build#L173
|
Amended commit message to match column guidelines |
|
pinging @nodejs/build again |
|
I think this has been obsoleted by 17665af. |
|
Hmm, maybe? It's possible that the default should still be changed? 17665af#diff-e2d5a00791bce9a01f99bc6fd613a39dR618 |
|
Maybe not obsoleted then but it certainly needs rebasing. |
|
Is this still relevant? Does it still need rebasing? Ping @mnkhouri |
|
Someone beat me to the punch: 84dea1b Closing this PR |
This commit changes the default vfp name from 'vfpv2' to 'vfp', affecting
builds for ARM architectures older than ARMv7.
Valid options for 'arm_fpu' in gcc do NOT include 'vfpv2', causing gcc to
quit with
error: unrecognized argument in option ‘-mfpu=vfpv2’whenusing the configure script with
--dest-cpu=arm.Gyp also expects only
vfp, vfpv3-d16, vfpv3, neon.GCC reference for the
-mfpu=option:https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
Gyp makefile reference:
https://github.com/nodejs/node/blob/v4.0.0/Makefile.build#L173