test: change expected and actual values in assert call#27881
Closed
oksemonenko wants to merge 1 commit intonodejs:masterfrom
Closed
test: change expected and actual values in assert call#27881oksemonenko wants to merge 1 commit intonodejs:masterfrom
oksemonenko wants to merge 1 commit intonodejs:masterfrom
Conversation
BridgeAR
added
the
code-and-learn
ryzokuken
approved these changes
May 26, 2019
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM. Please 👍 to approve fast forwarding.
ChALkeR
approved these changes
May 26, 2019
lpinca
approved these changes
May 26, 2019
ZYSzys
approved these changes
May 26, 2019
Collaborator
addaleax
added
the
author ready
BridgeAR
approved these changes
May 26, 2019
cjihrig
approved these changes
May 26, 2019
Trott
approved these changes
May 27, 2019
Collaborator
gireeshpunathil
approved these changes
May 27, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 27, 2019
PR-URL: nodejs#27881 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in ac95c2f. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos
pushed a commit
that referenced
this pull request
May 28, 2019
PR-URL: #27881 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes