Closed
Conversation
Member
targos
commented
Jun 4, 2019
targos
commented
- Set maxBuffer to Infinity because the output can exceed 1MB.
- Fix error checking for perfScript
- Set maxBuffer to Infinity because the output can exceed 1MB. - Fix error checking for perfScript
Member
Author
Member
Author
|
Tentative CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/7243/ (I don't know if the executor has |
BridgeAR
approved these changes
Jun 4, 2019
BridgeAR
added
test
cjihrig
approved these changes
Jun 4, 2019
BethGriggs
approved these changes
Jun 4, 2019
mmarchini
approved these changes
Jun 5, 2019
Member
Author
|
This was included in #27364. Thanks for the reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.