Closed
Conversation
Member
Author
|
Not sure how to make a test where |
ZYSzys
reviewed
Jul 20, 2019
Member
ZYSzys
left a comment
There was a problem hiding this comment.
Logically speaking, we need to emit('close') if err and er are both null right ?
Member
Author
|
@ZYSzys yes? it will be emitted through the callback to |
Member
|
@nodejs/fs |
Member
Author
|
fixed through #29048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readable
destroywill emit'close'on error. No reason to emit it before. Will just cause the error to be emitted twice.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes