doc: add blanks around code fences#29366
Closed
nschonni wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Addresses Markdownlint MD031 rule warnings
nodejs-github-bot
added
build
Trott
approved these changes
Aug 29, 2019
jasnell
approved these changes
Aug 29, 2019
Fishrock123
approved these changes
Aug 29, 2019
trivikr
approved these changes
Aug 30, 2019
Member
trivikr
added
the
author ready
devsnek
approved these changes
Aug 30, 2019
Member
devsnek
left a comment
devsnek
left a comment
There was a problem hiding this comment.
does our markdown linter have a rule we could enable for this?
Member
Author
|
The remark-lint equivalent is Edit: Markdownlint also flags the HTML comments trailing the headings |
devnexen
approved these changes
Aug 30, 2019
Member
|
Landed in 9ab1e07 |
Trott
pushed a commit
that referenced
this pull request
Aug 31, 2019
Addresses Markdownlint MD031 rule warnings PR-URL: #29366 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Addresses Markdownlint MD031 rule warnings PR-URL: #29366 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Addresses Markdownlint MD031 rule warnings PR-URL: #29366 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes