doc: change urls directly from 'http' to 'https'#29422
Closed
SEWeiTung wants to merge 1 commit intonodejs:masterfrom
SEWeiTung:FixByAddings
Closed
doc: change urls directly from 'http' to 'https'#29422SEWeiTung wants to merge 1 commit intonodejs:masterfrom SEWeiTung:FixByAddings
SEWeiTung wants to merge 1 commit intonodejs:masterfrom
SEWeiTung:FixByAddings
Conversation
nodejs-github-bot
added
build
mscdex
reviewed
Sep 3, 2019
trivikr
reviewed
Sep 3, 2019
SEWeiTung
changed the title
jasnell
approved these changes
Sep 3, 2019
trivikr
approved these changes
Sep 4, 2019
bnoordhuis
requested changes
Sep 4, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Everything in deps/ are third-party dependencies. Don't change those, such changes only get lost on the next update.
There're some URLs with old links, change them together from 'http' to 'https'. Notice: 1. Since files of CHANGELOG may be generated through tools, I don't intend to change them together as the history track. 2. All the files in the 'deps' are of 3-rd parties, they will be overwritten for the next update, so avoid modifications for them.
Author
|
@bnoordhuis. Fixed. |
bnoordhuis
approved these changes
Sep 4, 2019
Member
They're all third-party sources that we vendor in. |
Member
Member
|
Landed in c6b7e74 |
Trott
pushed a commit
that referenced
this pull request
Sep 6, 2019
There're some URLs with old links, change them together from 'http' to 'https'. Notice: 1. Since files of CHANGELOG may be generated through tools, I don't intend to change them together as the history track. 2. All the files in the 'deps' are of 3-rd parties, they will be overwritten for the next update, so avoid modifications for them. PR-URL: #29422 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
There're some URLs with old links, change them together from 'http' to 'https'. Notice: 1. Since files of CHANGELOG may be generated through tools, I don't intend to change them together as the history track. 2. All the files in the 'deps' are of 3-rd parties, they will be overwritten for the next update, so avoid modifications for them. PR-URL: #29422 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're some URLs with old links, change them together from 'http' to
'https'.
Notice:
intend to change them together as the history track.
overwritten for the next update, so avoid modifications for them.
make -j4 test(UNIX), orvcbuild test(Windows) passes