Closed
Conversation
This is to accommodate Myles Borins otherwise ending up with multiple entries due to different casing in the email 🙂
nodejs-github-bot
added
meta
addaleax
commented
Sep 18, 2019
| Ben Noordhuis <info@bnoordhuis.nl> <ben@strongloop.com> | ||
| Ben Taber <ben.taber@gmail.com> | ||
| Benjamin Coe <bencoe@gmail.com> <ben@npmjs.com> | ||
| Benjamin Coe <bencoe@gmail.com> <bencoe@google.com> |
Member
Author
There was a problem hiding this comment.
@bcoe Is the gmail one your preferred one? That’s what this is assuming here but please correct me if I’m wrong.
Trott
approved these changes
Sep 18, 2019
ZYSzys
reviewed
Sep 19, 2019
gengjiawen
approved these changes
Sep 19, 2019
legendecas
reviewed
Sep 19, 2019
ZYSzys
approved these changes
Sep 19, 2019
patilharshal16
approved these changes
Sep 19, 2019
saghul
approved these changes
Sep 19, 2019
ssample812
approved these changes
Sep 19, 2019
lpinca
approved these changes
Sep 19, 2019
Member
Trott
added
the
author ready
Member
|
Landed in 7899a96...81fee01 |
Trott
pushed a commit
that referenced
this pull request
Sep 25, 2019
This is to accommodate Myles Borins otherwise ending up with multiple entries due to different casing in the email 🙂 PR-URL: #29608 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #29608 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
This is to accommodate Myles Borins otherwise ending up with multiple entries due to different casing in the email 🙂 PR-URL: #29608 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
PR-URL: #29608 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the authors list, and make the
.mailmapprocessing case-insensitive so that @MylesBorins doesn’t end up with multiple entries due to different casing in the email 🙂