doc: update style for iojs#297
Closed
chrisdickinson wants to merge 1 commit intonodejs:v1.xfrom
chrisdickinson:style-iojs-docs
Closed
doc: update style for iojs#297chrisdickinson wants to merge 1 commit intonodejs:v1.xfrom chrisdickinson:style-iojs-docs
chrisdickinson wants to merge 1 commit intonodejs:v1.xfrom
chrisdickinson:style-iojs-docs
Conversation
|
This is looking great 😁 Chiming in with a small nit: maybe the sidebar header and content header fonts should match? |
Member
|
all lgtm, I'm keen to have this merged so it can go in nightlies asap, can be tweaked over time |
Member
There was a problem hiding this comment.
Just curious, wouldn't the font-family be inherited from the body tag?
Contributor
Author
There was a problem hiding this comment.
These are pre elements, so they'll automatically inherit monospace.
Member
There was a problem hiding this comment.
Style nit: trailing newline.
Contributor
Author
There was a problem hiding this comment.
Addressed this in the merge.
Member
|
LGTM |
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Can we see how this looks with:
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
Contributor
|
Nice |
9 tasks
* updates the styling for the iojs docs * pulls the processing step for markdown files into a separate module * adds the ability to insert comments into the markdown
chrisdickinson
added a commit
that referenced
this pull request
Jan 12, 2015
* updates the styling for the iojs docs * pulls the processing step for markdown files into a separate module * adds the ability to insert comments into the markdown PR-URL: #297 Fixes: nodejs/iojs.org#23 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Merged in 9120f2b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a separate module
The rendered documents.
Fixes nodejs/iojs.org#23.