[v12.x backport] Windows CI job update changes#30725
Closed
joaocgreis wants to merge 2 commits intonodejs:v12.x-stagingfrom
Closed
[v12.x backport] Windows CI job update changes#30725joaocgreis wants to merge 2 commits intonodejs:v12.x-stagingfrom
joaocgreis wants to merge 2 commits intonodejs:v12.x-stagingfrom
Conversation
Don't exit vcbuild with error code 0 when cctest fails.
nodejs-github-bot
added
build
Collaborator
BethGriggs
approved these changes
Dec 2, 2019
2 tasks
Member
|
Since the original commits landed cleanly on v12.x-staging, I'm closing this. Thanks anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #30724 to v12. This is a cherry-pick without conflicts (but the same is not true for v10 and v8).
@nodejs/backporters I will update this with any feedback from the original PR. This needs to land soon after to avoid issues running CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes