doc: remove redundant properties from headers#31492
doc: remove redundant properties from headers#31492XhmikosR wants to merge 1 commit intonodejs:masterfrom XhmikosR:XhmikosR-patch-1
Conversation
|
This is basically doing what you recommended in #31460 (comment)? I'll take that off my list of things to do if so. :-D |
|
Yup :) I just rebased it, let me know if everything looks the same as in master (which it should). |
|
Rebased to eliminate the conflict caused by landing #31493. |
| h5 code, | ||
| h6 code { | ||
| color: inherit; | ||
| font-family: inherit; |
There was a problem hiding this comment.
font-family can be removed later too @Trott so that the code is using the same font as everywhere else. AFAICT only the color is needed
There was a problem hiding this comment.
font-familycan be removed later too @Trott so that the code is using the same font as everywhere else. AFAICT only the color is needed
I thought about doing that in a second commit here, but I want to make sure there aren't any weird kerning issues or anything when we do that. So I was going to save that for another PR. I'm really good at rationalizing dividing CSS changes across multiple PRs apparently. But if you're more confident it won't be a problem, feel free to add it to this one.
There was a problem hiding this comment.
I actually meant to make it in a separate PR later. Now that the selectors are split, it should be easier to maintain.
Trott
added
the
author ready
PR-URL: #31492 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 70c32a6 🎉 |
PR-URL: #31492 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #31492 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #31492 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #31492 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
4 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis is not fully tested, just with Firefox on Windows 10. I'll need to rebase it after #31460, I'll do it later
/CC @Trott