lib: fix few comment typos in fs/watchers.js#31705
Closed
lundibundi wants to merge 3 commits intonodejs:masterfrom
Closed
lib: fix few comment typos in fs/watchers.js#31705lundibundi wants to merge 3 commits intonodejs:masterfrom
lundibundi wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
fs
Trott
reviewed
Feb 9, 2020
Trott
reviewed
Feb 9, 2020
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Trott
approved these changes
Feb 9, 2020
BridgeAR
approved these changes
Feb 9, 2020
BridgeAR
added
the
author ready
cjihrig
approved these changes
Feb 9, 2020
devnexen
approved these changes
Feb 9, 2020
addaleax
approved these changes
Feb 9, 2020
Collaborator
antsmartian
approved these changes
Feb 10, 2020
jasnell
approved these changes
Feb 10, 2020
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Feb 13, 2020
PR-URL: #31705 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in bc55b57 |
Member
|
@lundibundi should this go back to v13.x? It'll need a manual backport if yes. |
Member
Author
|
I don't think it is needed unless it will help with other conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes