Skip to content

dns: Add dns.ALL hints flag constant#32183

Closed
murgatroid99 wants to merge 2 commits intonodejs:masterfrom
murgatroid99:dns_support_AI_ALL
Closed

dns: Add dns.ALL hints flag constant#32183
murgatroid99 wants to merge 2 commits intonodejs:masterfrom
murgatroid99:dns_support_AI_ALL

Conversation

@murgatroid99
Copy link
Contributor

@murgatroid99 murgatroid99 commented Mar 10, 2020

This change adds the dns.ALL flag and allows it to be passed in the dns.lookup hints option. I changed the relevant tests that I could find and added some basic documentation.

The documentation I wrote for that flag is based on how it is documented in man 3 getaddrinfo. However, the reason for this change is that we recently discovered that getaddrinfo (and therefore dns.lookup) behaves differently on different operating systems. In particular, on Linux it behaves as documented, but on Mac, the default behavior of getaddrinfo is as though the AI_ADDRCONFIG flag is set, and AI_ALL makes it act as though that flag is unset (i.e. the default Linux behavior). Setting AI_ALL appears to be the only way to get that behavior on Mac, and that is why I would like it to be available.

I am not sure if it would be better to explicitly document that part of the OS-specific behavior in the dns module documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Mar 10, 2020
@murgatroid99 murgatroid99 mentioned this pull request Mar 10, 2020
Merged
@addaleax addaleax added dns Issues and PRs related to the dns subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Mar 13, 2020
addaleax
addaleax reviewed Mar 13, 2020
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29814/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30212/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30247/

addaleax pushed a commit that referenced this pull request Mar 30, 2020
@murgatroid99 @addaleax
dns: add dns.ALL hints flag constant
18c3ff9 
PR-URL: #32183
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

addaleax commented Mar 30, 2020

Landed in 18c3ff9

@addaleax addaleax closed this Mar 30, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
@murgatroid99 @addaleax
dns: add dns.ALL hints flag constant
e14317a 
PR-URL: #32183
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Apr 2, 2020
@addaleax
doc: add missing changes: entry for dns.ALL
5118712 
Refs: nodejs#32183
@addaleax addaleax mentioned this pull request Apr 2, 2020
Closed
3 tasks
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

This should not be released without #32617

addaleax added a commit that referenced this pull request Apr 2, 2020
@addaleax
doc: add missing changes: entry for dns.ALL
5661121 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@addaleax @BethGriggs
doc: add missing changes: entry for dns.ALL
1bec3ac 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@addaleax @targos
doc: add missing changes: entry for dns.ALL
3296359 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos added a commit that referenced this pull request Apr 14, 2020
@targos
2020-04-14, Version 13.13.0 (Current)
4ca9571 
Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813
targos added a commit that referenced this pull request Apr 14, 2020
@targos
2020-04-14, Version 13.13.0 (Current)
8130521 
Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813
targos added a commit that referenced this pull request Apr 14, 2020
@targos
2020-04-14, Version 13.13.0 (Current)
cf4c332 
Notable changes:

New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
  This function takes an array of `ArrayBufferView` elements and will
  write the data it reads sequentially to the buffers
  (Sk Sajidul Kadir). #32356
* A new overload is available for `fs.readSync`, which allows to
  optionally pass any of the `offset`, `length` and `position`
  parameters. #32460

Other changes:
* dns:
  * Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
    `dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
    mapped IPv6 addresses (murgatroid99).
    #32183
* http:
  * The default maximum HTTP header size was changed from 8KB to 16KB
    (rosaxny). #32520
* n-api:
  * Calls to `napi_call_threadsafe_function` from the main thread can
    now return the `napi_would_deadlock` status in certain
    circumstances (Gabriel Schulhof).
    #32689
* util:
  * Added a new `maxStrLength` option to `util.inspect`, to control the
    maximum length of printed strings. Its default value is `Infinity`
    (rosaxny). #32392
* worker:
  * Added support for passing a `transferList` along with `workerData`
    to the `Worker` constructor (Juan José Arboleda).
    #32278

New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. #32734
* flarna (Gerhard Stoebich). #32620
* mildsunrise (Alba Mendez). #32525

PR-URL: #32813
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@murgatroid99 @targos
dns: add dns.ALL hints flag constant
ae1ad19 
PR-URL: nodejs#32183
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@addaleax @targos
doc: add missing changes: entry for dns.ALL
b21e792 
Refs: nodejs#32183

PR-URL: nodejs#32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@murgatroid99 @targos
dns: add dns.ALL hints flag constant
b7d264e 
PR-URL: #32183
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@addaleax @targos
doc: add missing changes: entry for dns.ALL
a55d215 
Refs: #32183

PR-URL: #32617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@murgatroid99 @nodejs-github-bot @addaleax @jasnell @targos