[v13.x backport] stream: avoid destroying writable source#32211
Closed
ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
Closed
[v13.x backport] stream: avoid destroying writable source#32211ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
Conversation
ronag
force-pushed
the
backport-32198-to-v13.x
branch
from
030d93e to
3a6c542
Compare
ronag
force-pushed
the
backport-32198-to-v13.x
branch
from
3a6c542 to
f99b2ef
Compare
Collaborator
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Fixes: nodejs@4d93e10#commitcomment-37751035 Backport-PR-URL: nodejs#32211
ronag
force-pushed
the
backport-32198-to-v13.x
branch
from
f99b2ef to
a0f3d2b
Compare
Member
Author
|
fixed conflict |
Collaborator
Member
Author
|
included in #32212 in order to avoid multiple steps of conflicts |
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #32198
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes