doc: use uppercase on windows path#32294
Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
bzoz
approved these changes
Mar 16, 2020
Contributor
bzoz
left a comment
bzoz
left a comment
There was a problem hiding this comment.
LGTM! Looks like we are using C: everywhere else in those docs.
jasnell
approved these changes
Mar 16, 2020
lpinca
approved these changes
Mar 16, 2020
2 tasks
trivikr
approved these changes
Mar 18, 2020
ExE-Boss
approved these changes
Mar 18, 2020
Member
Author
This not the responsibility of this PR. I think |
Member
While true, it wouldn't hurt to go ahead and update here. |
addaleax
approved these changes
Mar 29, 2020
addaleax
added
the
author ready
Member
|
Landed in cc8066e |
addaleax
pushed a commit
that referenced
this pull request
Mar 29, 2020
PR-URL: #32294 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32294 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32294 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist