Skip to content

test: improve test-cluster-net-listen-ipv6only-* tests#32381

Merged
Trott merged 2 commits intonodejs:masterfrom
Trott:seq-cluster
Mar 22, 2020
Merged

test: improve test-cluster-net-listen-ipv6only-* tests#32381
Trott merged 2 commits intonodejs:masterfrom
Trott:seq-cluster

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 20, 2020 •
edited
Loading

  • Replace Map with Array
  • Add additional checks that code/test work as expected (Failed on Windows so I took it out.)
  • Use Promise.all() in place of countdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 20, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
BridgeAR
BridgeAR approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2020
jasnell
jasnell reviewed Mar 21, 2020
View reviewed changes
jasnell
jasnell reviewed Mar 21, 2020
View reviewed changes
@trivikr trivikr removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29961/ ✔️

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2020
@Trott Trott mentioned this pull request Mar 21, 2020
Merged
2 tasks
Trott added 2 commits March 21, 2020 21:51
@Trott
test: replace Map with Array in cluster-net-listen tests
7d4dedb 
PR-URL: nodejs#32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
test: replace countdown with Promise.all() in cluster-net-listen tests
ecfb7b0 
PR-URL: nodejs#32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Mar 22, 2020

Landed in 1d49558...ecfb7b0

@Trott Trott merged commit ecfb7b0 into nodejs:master Mar 22, 2020
@Trott Trott deleted the seq-cluster branch March 22, 2020 04:53
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace Map with Array in cluster-net-listen tests
347f707 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace countdown with Promise.all() in cluster-net-listen tests
e2ee68e 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace Map with Array in cluster-net-listen tests
bdcc11f 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: replace countdown with Promise.all() in cluster-net-listen tests
2e28783 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace Map with Array in cluster-net-listen tests
1b79174 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: replace countdown with Promise.all() in cluster-net-listen tests
97e352d 
PR-URL: #32381
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @nodejs-github-bot @jasnell @addaleax @BridgeAR @trivikr