Skip to content

src: large pages support for illumos/solaris systems.#34320

Closed
devnexen wants to merge 1 commit intonodejs:masterfrom
devnexen:illumos_large_pages
Closed

src: large pages support for illumos/solaris systems.#34320
devnexen wants to merge 1 commit intonodejs:masterfrom
devnexen:illumos_large_pages

Conversation

@devnexen
Copy link
Contributor

@devnexen devnexen commented Jul 12, 2020

  • Making sure using apis supported by both.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@devnexen devnexen requested a review from gabrielschulhof July 12, 2020 06:11
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jul 12, 2020
@devnexen devnexen force-pushed the illumos_large_pages branch from 4b406ab to 6c11263 Compare July 12, 2020 07:00
@devnexen
Copy link
Contributor Author

devnexen commented Jul 22, 2020

ping @gabrielschulhof :-)

@devnexen devnexen requested a review from addaleax August 14, 2020 08:28
lundibundi
lundibundi reviewed Aug 24, 2020
View reviewed changes
@lundibundi
Copy link
Member

lundibundi commented Aug 24, 2020

ping @gabrielschulhof @addaleax based on recent changes to those files.

@lundibundi lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32918/

@devnexen devnexen force-pushed the illumos_large_pages branch 2 times, most recently from c168c24 to 6c11263 Compare August 26, 2020 07:15
@lundibundi
Copy link
Member

lundibundi commented Sep 2, 2020

ping @devnexen could you please clarify questions in my review and I guess this is ready to land after that?

Also, is there no solaris on our CI?

@devnexen
Copy link
Contributor Author

devnexen commented Sep 2, 2020

sorry for having dismissed your primary question...

@devnexen
src: large pages support for illumos/solaris systems.
68c5d50 
 * Making sure using apis supported by both.
@richardlau
Copy link
Member

richardlau commented Sep 2, 2020

Also, is there no solaris on our CI?

The closest we have in the CI is SmartOS.

@lundibundi
Copy link
Member

lundibundi commented Sep 2, 2020

@devnexen no problem 👍

Then I guess we just have to format this with clang-format and this can land.

@devnexen devnexen force-pushed the illumos_large_pages branch from 6c11263 to 68c5d50 Compare September 2, 2020 13:54
@lundibundi lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33013/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33018/

gabrielschulhof
gabrielschulhof approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lundibundi lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33662/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 16, 2020 •
edited by gabrielschulhof
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33670/ ✔️

@gabrielschulhof gabrielschulhof added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2020
devnexen added a commit that referenced this pull request Oct 19, 2020
@devnexen
src: large pages support in illumos/solaris systems
2b3acc4 
    Making sure using apis supported by both.

    PR-URL: #34320
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Oct 19, 2020

Landed on 2b3acc4.

@aduh95 aduh95 closed this Oct 19, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@devnexen @BethGriggs
src: large pages support in illumos/solaris systems
15dd903 
    Making sure using apis supported by both.

    PR-URL: #34320
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@devnexen @BethGriggs
src: large pages support in illumos/solaris systems
9800668 
    Making sure using apis supported by both.

    PR-URL: #34320
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@devnexen @BethGriggs
src: large pages support in illumos/solaris systems
00d9499 
    Making sure using apis supported by both.

    PR-URL: #34320
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@addaleax addaleax Awaiting requested review from addaleax

+1 more reviewer

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@devnexen @lundibundi @nodejs-github-bot @richardlau @aduh95 @fhinkel @jasnell @gabrielschulhof