quic: resolving more outstanding TODO comments#34865
Closed
jasnell wants to merge 5 commits intonodejs:masterfrom
Closed
quic: resolving more outstanding TODO comments#34865jasnell wants to merge 5 commits intonodejs:masterfrom
jasnell wants to merge 5 commits intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
added
dont-land-on-v14.x
quic
jasnell
force-pushed
the
quic-cleanups-16
branch
from
35a9089 to
fbb186b
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Aug 22, 2020
This comment has been minimized.
This comment has been minimized.
jasnell
force-pushed
the
quic-cleanups-16
branch
from
85c14ad to
ae5f5b1
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
quic-cleanups-16
branch
from
2ac12e9 to
097e960
Compare
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32915/ Windows CI runs appear to be failing for reasons unrelated to this PR. |
4 tasks
lundibundi
reviewed
Aug 24, 2020
lundibundi
approved these changes
Aug 24, 2020
This was referenced Aug 25, 2020
Collaborator
Contributor
|
@jasnell is it ready to land? |
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
I'll be working on the quic stuff again in a few weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing to resolve some outstanding TODO statements...
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes