crypto: implement webcrypto.randomUUID#39648
Closed
targos wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
crypto
Member
Author
|
/cc @bcoe |
aduh95
reviewed
Aug 3, 2021
jasnell
approved these changes
Aug 3, 2021
tniessen
reviewed
Aug 3, 2021
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Does this PR intentionally add the Web Crypto WPTs? If so, that seems like a major change regardless of randomUUID support and should probably be at least mentioned in the commit message, or separated from the change (e.g., in a separate commit).
benjamingr
approved these changes
Aug 4, 2021
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
+1 with Tobias's comment - I'd prefer that to be a separate commit though not blocking/a huge deal to me. (I agree it's bigger than re-exposing randomUUID on webcrypto.randomUUID)
targos
force-pushed
the
webcrypto-randomuuid
branch
from
43aad6b to
0ba70d5
Compare
Member
Author
|
Split into two commits |
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
tniessen
approved these changes
Aug 4, 2021
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Thanks for splitting the changes into separate commits.
Collaborator
targos
added
the
semver-minor
targos
added a commit
that referenced
this pull request
Aug 5, 2021
Refs: https://wicg.github.io/uuid/ Refs: https://www.chromestatus.com/feature/5689159362543616 PR-URL: #39648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
added a commit
that referenced
this pull request
Aug 5, 2021
PR-URL: #39648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Member
Author
|
Landed in 58316e2...0220497 |
Contributor
|
@targos awesome 🥳 |
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Refs: https://wicg.github.io/uuid/ Refs: https://www.chromestatus.com/feature/5689159362543616 PR-URL: #39648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39648 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://wicg.github.io/uuid/
Refs: https://www.chromestatus.com/feature/5689159362543616