[v14.x] deps: upgrade openssl to OpenSSL_1_1_1l#39868
Closed
richardlau wants to merge 2 commits intonodejs:v14.x-stagingfrom
Closed
[v14.x] deps: upgrade openssl to OpenSSL_1_1_1l#39868richardlau wants to merge 2 commits intonodejs:v14.x-stagingfrom
richardlau wants to merge 2 commits intonodejs:v14.x-stagingfrom
Conversation
github-actions
bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
Member
Author
|
cc @nodejs/crypto Is anyone able to validate this? I followed https://github.com/nodejs/node/blob/master/doc/guides/maintaining-openssl.md but 5000+ changed files seems like a lot. |
Member
Author
Seems like previously we didn't have |
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1l.tar.gz
$ mv openssl-1.1.1l openssl
$ git add --all openssl
$ git commit openssl
Member
Author
|
Ah okay I think this is possibly a discrepancy between cloning from GitHub vs the tarball. |
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
richardlau
force-pushed
the
v14.x-openssl1.1.1l
branch
from
8aa2b89 to
44d7cbc
Compare
Member
Author
|
Updated to use the OpenSSL tarball. |
Collaborator
Collaborator
mildsunrise
approved these changes
Aug 25, 2021
Collaborator
Member
Author
|
I've opened a PR to update the maintaining openssl guide to clarify updating for 14.x/12.x: #39878 |
tniessen
approved these changes
Aug 26, 2021
MylesBorins
pushed a commit
that referenced
this pull request
Aug 28, 2021
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1l.tar.gz
$ mv openssl-1.1.1l openssl
$ git add --all openssl
$ git commit openssl
PR-URL: #39868
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 28, 2021
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: #39868
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Contributor
|
Landed in 84ed5b0...f8b4dc1 |
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Aug 28, 2021
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1l.tar.gz
$ mv openssl-1.1.1l openssl
$ git add --all openssl
$ git commit openssl
PR-URL: nodejs#39868
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Aug 28, 2021
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: nodejs#39868
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1l.tar.gz
$ mv openssl-1.1.1l openssl
$ git add --all openssl
$ git commit openssl
PR-URL: nodejs#39868
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/include/crypto/bn_conf.h
$ git add deps/openssl/openssl/include/crypto/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: nodejs#39868
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates from https://github.com/openssl/openssl/releases/tag/OpenSSL_1_1_1l (openssl/openssl@fb047eb).