build: include new public V8 headers in distribution#40423
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
build: include new public V8 headers in distribution#40423targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
v8.h was split into a multitude of smaller headers. Refs: nodejs#39876
nodejs-github-bot
added
build
aduh95
approved these changes
Oct 12, 2021
joyeecheung
approved these changes
Oct 12, 2021
richardlau
approved these changes
Oct 12, 2021
2 tasks
BethGriggs
approved these changes
Oct 12, 2021
cjihrig
approved these changes
Oct 12, 2021
targos
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
22 tasks
Collaborator
BethGriggs
added
the
fast-track
Contributor
|
Fast-track has been requested by @BethGriggs. Please 👍 to approve. |
Member
|
Landed in f9996d5 |
mhdawson
pushed a commit
that referenced
this pull request
Oct 13, 2021
v8.h was split into a multitude of smaller headers. Refs: #39876 PR-URL: #40423 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
22 tasks
This was referenced Oct 15, 2021
This was referenced Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8.h was split into a multitude of smaller headers.
Refs: #39876