readline: skip escaping characters again#41005
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Dec 1, 2021
Merged
readline: skip escaping characters again#41005nodejs-github-bot merged 1 commit intonodejs:masterfrom
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Conversation
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Collaborator
targos
approved these changes
Nov 29, 2021
Collaborator
benjamingr
approved these changes
Nov 29, 2021
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
(I hate boolean traps but this doesn't add one :D)
BridgeAR
added
the
author ready
jasnell
approved these changes
Nov 29, 2021
addaleax
approved these changes
Nov 29, 2021
BridgeAR
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in bbed2a7 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#41005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This is a minor performance improvement for readline. It skips to escape individual characters again after escaping them before. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor performance improvement for readline. It skips to
escape individual characters again after escaping them before.
Signed-off-by: Ruben Bridgewater ruben@bridgewater.de