stream: throw error if stream has been destroyed on _final and _write#41164
Closed
JPedroAmorim wants to merge 1 commit intonodejs:mainfrom
Closed
stream: throw error if stream has been destroyed on _final and _write#41164JPedroAmorim wants to merge 1 commit intonodejs:mainfrom
JPedroAmorim wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
JPedroAmorim
force-pushed
the
issue/39030
branch
from
6df81c4 to
5e20d05
Compare
Contributor
|
This needs test(s). |
mcollina
added
needs-citgm
Collaborator
mscdex
reviewed
Mar 15, 2022
| called = true; | ||
|
|
||
| state.pendingcb--; | ||
| if (!err && state.destroyed) { |
Contributor
There was a problem hiding this comment.
We could move this into the if-else block below to make it a bit cleaner:
if (err) {
// ...
} else if (state.destroyed) {
// ...
} else if (needFinish(state)) {
// ...
}
ronag
reviewed
Mar 15, 2022
Member
ronag
left a comment
ronag
left a comment
There was a problem hiding this comment.
This looks wrong to me but I don't have time to provide proper feedback atm.
This was referenced Mar 16, 2022
Contributor
|
This would need to be rebased if we still want to merge it. |
Contributor
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Contributor
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #39030