build: include v8-fast-api-calls.h in bundle#41359
Closed
zbjornson wants to merge 1 commit intonodejs:masterfrom
Closed
build: include v8-fast-api-calls.h in bundle#41359zbjornson wants to merge 1 commit intonodejs:masterfrom
zbjornson wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
This API is still experimental, but it's not really possible to experiment with it without this header.
zbjornson
force-pushed
the
fast-api-header
branch
from
c0d01da to
4d8f9f7
Compare
github-actions
bot
removed
the
request-ci
Collaborator
24 tasks
RaisinTen
requested changes
Jan 1, 2022
Member
There was a problem hiding this comment.
This API is still experimental
Then we probably shouldn't include this yet.
but it's not really possible to experiment with it without this header
As @targos already mentioned in #37570 (comment), you could include a copy of the header like how isolated-vm includes the inspector headers - https://github.com/laverdet/isolated-vm/tree/HEAD/vendor/v8_inspector.
This was referenced Jan 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API is still experimental, but it's not really possible to experiment with it without this header.
I don't know if this is the only file that needs to be changed. I don't think I have a way to test this PR.