deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff#41564
deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff#41564luyahan wants to merge 0 commit intonodejs:v16.x-stagingfrom
Conversation
|
Review requested:
|
|
@luyahan Hi, I‘m trying to build nodejs v16.13.1 these days. By applying your patch 1 and 2 ( |
thanks your info ,i will to look it. |
gengjiawen
left a comment
There was a problem hiding this comment.
@luyahan You may need use https://github.com/nodejs/node-core-utils/blob/main/docs/git-node.md#git-node-v8-backport-sha
Generally you need bump common.gypi and we generally not squash cherrypick commit
@gengjiawen I run git node backport What can i do to fix conflict? I can't find any conflicts in edit. |
Not sure (is you local branch reset to |
|
I think it's okay to squash all fixes here since they all apply to the same platform. |
I am okay with this. So only bump |
|
@luyahan did you target v16.x-staging because the fixes are already in v17.x ? |
This pacth can fix Refs: v8/v8@77599ff |
Yes, these patch had been add into v17.x. |
|
I reopen this pr in #41566 |
Fix riscv64 segment fault
origin commit :
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff