tools: fix stability index generation#45346
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Nov 7, 2022
Merged
Conversation
nodejs-github-bot
added
doc
Member
|
An alternative is in f747806. I'm not sure which one is easier to understand. (I mean, I think it's the one I wrote, but that's because I wrote it.) This looks good to me, though, and I suspect is the better fix. |
Trott
approved these changes
Nov 6, 2022
Contributor
Author
This PR changes the JSON output, because I don't think having line returns in there is helpful, and it can break stuff as shown in the other PR. We could also land both PRs if we keep this one focused on the JSON output and yours on the stability index table generation. (I think that regex of yours is not easier to understand than this PR, but I don't feel strongly either way). |
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
GeoffreyBooth
approved these changes
Nov 6, 2022
github-actions
bot
removed
the
request-ci
Collaborator
Trott
added
the
author ready
Collaborator
18 tasks
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 7e581c8 |
This was referenced Nov 8, 2022
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
PR-URL: nodejs#45346 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
20 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45346 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45346 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45346 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45346 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45346 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.