lib: allow http.OutgoingMessage to be used in Writable.toWeb()#45642
Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom Dec 10, 2022
Merged
lib: allow http.OutgoingMessage to be used in Writable.toWeb()#45642nodejs-github-bot merged 5 commits intonodejs:mainfrom
nodejs-github-bot merged 5 commits intonodejs:mainfrom
Conversation
debadree25
changed the title
debadree25
changed the title
jasnell
approved these changes
Nov 27, 2022
cjihrig
reviewed
Nov 27, 2022
Member
Author
|
@cjihrig have updated the tests do review! |
Contributor
|
Thanks. I've started the GitHub Actions CI for you. |
Member
Author
|
It appears some of the CI tests are failing working on fixing them |
Member
Author
|
Ok it seems that the changes i made are resulting in issues with duplexes somehow, trying to get to the bottom of this, if anybody has any insight on this would love to hear Thank you! |
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: nodejs#44188
…to the one mentioned in the issue
debadree25
force-pushed
the
fix/to-web-allow-server-reponse
branch
from
f73e049 to
190611b
Compare
debadree25
changed the title
Member
Author
|
Have linted the commit message and fixed the reasons causing the tests with duplexes to fail, we can have another CI run Thank You |
anonrig
approved these changes
Nov 29, 2022
Member
Author
|
I guess we could have CI on this PR? |
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2ec4189 |
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Dec 12, 2022
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: nodejs#44188 PR-URL: nodejs#45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
Attempted to fix the issue by watering down the condition being checked in internal/streams/utils isWritableNodeStream utility Fixes: #44188 PR-URL: #45642 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted to fix the issue by watering down the condition being checked in lib/internal/webstreams/adapters.js similar to
isWritableNodeStream utility being used in internal/streams/utils
Fixes: #44188