stream: prevent memory overflow due to the default strategy

[lilsweetcaligula]

Fixes: #47128

[zizifn]

Any update on this fix? I met this issue when converting Socket via Readable.toWeb... Switching back to Readable will not have any memory issues..

[aduh95]

Ping @nodejs/streams for reviews

[ronag]

I think we might need a separate team for web-streams. I have no idea here... 🤷

[MattiasBuelens]

Here's a different idea: when given a non-object mode stream, can we make Readable.toWeb() return a readable byte stream instead, i.e. new ReadableStream({ type: 'bytes' })? Then { highWaterMark } as a strategy would work just fine, plus users would now be able to use a BYOB reader on the returned stream.

I suppose this might behave differently if an encoding was set using new Readable({ encoding }) or readable.setEncoding(encoding). In that case, the Readable will produce string chunks, which ReadableByteStreamController.enqueue() doesn't accept. We could try to reset the readable's encoding when calling toWeb(), so we get the raw bytes back. Or, if all else fails, we could just decode each string chunk when it's received. 🤷