net: set default highwatermark at socket creation time by lukiano · Pull Request #48882 · nodejs/node

lukiano · 2023-07-22T00:30:16Z

This PR is to make a recent code changes backwards compatible with previous releases of Node.JS, as depicted in #47405 (comment)

nodejs-github-bot · 2023-07-22T00:30:21Z

Review requested:

@nodejs/net

lukiano · 2023-07-22T00:32:02Z

lib/net.js

  if (typeof options.highWaterMark !== 'undefined') {
    validateNumber(
      options.highWaterMark, 'options.highWaterMark',
+      0


I'm throwing an error if options.highWaterMark is less than zero. Alternatively, we can fallback to a default value of undefined.

I'm okay with being more strict and forbid negative values.

lukiano · 2023-07-22T00:33:09Z

lib/net.js

  this.keepAlive = Boolean(options.keepAlive);
  this.keepAliveInitialDelay = ~~(options.keepAliveInitialDelay / 1000);
-  this.highWaterMark = options.highWaterMark ?? getDefaultHighWaterMark();
+  this.highWaterMark = options.highWaterMark ?? undefined;


Theoretically this.highWaterMark = options.highWaterMark; should suffice if we are happy with falsy values.

Yes, let's accept falsy values.

ShogunPanda · 2023-07-22T08:24:56Z

Can you also please fix linter issues?

ShogunPanda · 2023-07-22T13:16:47Z

LGTM now.
Can you also update docs?

mcollina · 2023-07-24T08:21:54Z

Tests are failing

lukiano · 2023-07-24T11:46:11Z

I've amended the tests.

lukiano · 2023-07-24T11:49:53Z

I've also made the procedure more evident in the documentation.

ShogunPanda

LGTM!

lukiano · 2023-07-24T20:15:40Z

Fixed some linting issues.

lpinca · 2023-07-27T19:41:24Z

doc/api/http.md

    `readableHighWaterMark` and `writableHighWaterMark`. This affects
    `highWaterMark` property of both `IncomingMessage` and `ServerResponse`.
-    **Default:** See [`stream.getDefaultHighWaterMark()`][].
+    **Default:** `undefined`. Sockets will use the default watermark value at the time the request arrives. See [`stream.getDefaultHighWaterMark()`][].


I would keep it consistent and add a line break after 80 characters.

The lint job fails for this reason.

nodejs-github-bot · 2023-07-28T10:19:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52964/

nodejs-github-bot · 2023-08-10T13:00:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53127/

aduh95 · 2023-09-29T10:37:26Z

This needs a rebase to fix the git conflicts.

lukiano · 2023-09-29T11:06:23Z

Thanks. Rebased

nodejs-github-bot · 2023-09-30T09:55:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54403/

nodejs-github-bot · 2023-10-30T11:18:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55330/

nodejs-github-bot · 2023-11-11T16:25:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55572/

nodejs-github-bot · 2023-11-20T09:08:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55778/

nodejs-github-bot · 2023-11-20T19:40:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55797/

nodejs-github-bot · 2023-11-21T15:45:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55828/

nodejs-github-bot · 2023-12-26T15:06:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56538/

aduh95 · 2025-02-23T00:04:13Z

This needs another rebase unfortunately

github-actions · 2025-11-08T20:26:16Z

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions · 2025-12-09T00:02:02Z

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jul 22, 2023

lukiano commented Jul 22, 2023

View reviewed changes

lukiano force-pushed the fix/watermark-at-socket-creation branch from a6dc57b to d6e7851 Compare July 22, 2023 12:37

lukiano force-pushed the fix/watermark-at-socket-creation branch from d6e7851 to 624f697 Compare July 24, 2023 11:45

lukiano force-pushed the fix/watermark-at-socket-creation branch from 624f697 to b0572e0 Compare July 24, 2023 11:49

ShogunPanda approved these changes Jul 24, 2023

View reviewed changes

lukiano force-pushed the fix/watermark-at-socket-creation branch from b0572e0 to 9f859b9 Compare July 24, 2023 20:14

lpinca added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 27, 2023

lpinca approved these changes Jul 27, 2023

View reviewed changes

lukiano force-pushed the fix/watermark-at-socket-creation branch from 9f859b9 to 18696df Compare July 28, 2023 10:08

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2023

This was referenced Jul 29, 2023

CI Reliability 2023-07-29 nodejs/reliability#627

Open

CI Reliability 2023-07-30 nodejs/reliability#628

Open

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023

github-actions bot mentioned this pull request Aug 11, 2023

CI Reliability 2023-08-11 nodejs/reliability#634

Open

29 tasks

net: set default highwatermark at socket creation time

3a500ba

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2023

This was referenced Oct 1, 2023

CI Reliability 2023-10-01 nodejs/reliability#680

Open

CI Reliability 2023-10-02 nodejs/reliability#681

Open

CI Reliability 2023-10-03 nodejs/reliability#682

Open

jasnell approved these changes Oct 28, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023

This was referenced Oct 31, 2023

CI Reliability 2023-10-31 nodejs/reliability#703

Open

CI Reliability 2023-11-01 nodejs/reliability#704

Open

CI Reliability 2023-11-02 nodejs/reliability#705

Open

This was referenced Nov 12, 2023

CI Reliability 2023-11-12 nodejs/reliability#715

Open

CI Reliability 2023-11-13 nodejs/reliability#716

Open

CI Reliability 2023-11-14 nodejs/reliability#717

Open

CI Reliability 2023-11-15 nodejs/reliability#718

Open

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2023

aduh95 added the stalled Issues and PRs that are stalled. label Nov 8, 2025

github-actions bot closed this Dec 9, 2025

Uh oh!

Conversation

lukiano commented Jul 22, 2023

Uh oh!

nodejs-github-bot commented Jul 22, 2023

Uh oh!

lukiano Jul 22, 2023

Choose a reason for hiding this comment

Uh oh!

ShogunPanda Jul 22, 2023

Choose a reason for hiding this comment

Uh oh!

lukiano Jul 22, 2023

Choose a reason for hiding this comment

Uh oh!

ShogunPanda Jul 22, 2023

Choose a reason for hiding this comment

Uh oh!

ShogunPanda commented Jul 22, 2023

Uh oh!

ShogunPanda commented Jul 22, 2023

Uh oh!

mcollina commented Jul 24, 2023

Uh oh!

lukiano commented Jul 24, 2023

Uh oh!

lukiano commented Jul 24, 2023

Uh oh!

ShogunPanda left a comment

Choose a reason for hiding this comment

Uh oh!

lukiano commented Jul 24, 2023

Uh oh!

lpinca Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

lpinca Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

lukiano Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jul 28, 2023

Uh oh!

nodejs-github-bot commented Aug 10, 2023

Uh oh!

aduh95 commented Sep 29, 2023

Uh oh!

lukiano commented Sep 29, 2023

Uh oh!

nodejs-github-bot commented Sep 30, 2023

Uh oh!

nodejs-github-bot commented Oct 30, 2023

Uh oh!

nodejs-github-bot commented Nov 11, 2023

Uh oh!

nodejs-github-bot commented Nov 20, 2023

Uh oh!

nodejs-github-bot commented Nov 20, 2023

Uh oh!

nodejs-github-bot commented Nov 21, 2023

Uh oh!

nodejs-github-bot commented Dec 26, 2023

Uh oh!

aduh95 commented Feb 23, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants