test: fix argument computation in embedtest

[joyeecheung]

bootstrap: do not expand argv1 for snapshots

To avoid capturing build machine states into the snapshot

test: fix argument computation in embedtest

There were a few bugs in the original test that went unnoticed
because with the bug the test did not actually get run anymore.
This patch fixes the argument computation by accounting filtering
of the arguments, and uses spawnSyncAndExit{WithoutError} in
the test to enable better logging when the test fails.

build: run embedtest using node executable

We should use the node executable to run this test, instead of
counting on embedtest, the binary being tested, as the test runner.
Otherwise bugs can go unnoticed if the embedtest binary itself
does not work correctly.

Fixes: #49501

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53767/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53813/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53885/

[joyeecheung]

Can I have some reviews please? @nodejs/startup @nodejs/cpp-reviewers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53932/

[joyeecheung]

@nodejs/build-files @nodejs/cpp-reviewers can I get some reviews please?

[RaisinTen]

Should we sync the code in the embedding docs (

node/doc/api/embedding.md

Lines 112 to 166 in 6a489df

	int RunNodeInstance(MultiIsolatePlatform* platform,
	const std::vector<std::string>& args,
	const std::vector<std::string>& exec_args) {
	int exit_code = 0;
	// Setup up a libuv event loop, v8::Isolate, and Node.js Environment.
	std::vector<std::string> errors;
	std::unique_ptr<CommonEnvironmentSetup> setup =
	CommonEnvironmentSetup::Create(platform, &errors, args, exec_args);
	if (!setup) {
	for (const std::string& err : errors)
	fprintf(stderr, "%s: %s\n", args[0].c_str(), err.c_str());
	return 1;
	}
	Isolate* isolate = setup->isolate();
	Environment* env = setup->env();
	{
	Locker locker(isolate);
	Isolate::Scope isolate_scope(isolate);
	HandleScope handle_scope(isolate);
	// The v8::Context needs to be entered when node::CreateEnvironment() and
	// node::LoadEnvironment() are being called.
	Context::Scope context_scope(setup->context());
	// Set up the Node.js instance for execution, and run code inside of it.
	// There is also a variant that takes a callback and provides it with
	// the `require` and `process` objects, so that it can manually compile
	// and run scripts as needed.
	// The `require` function inside this script does *not* access the file
	// system, and can only load built-in Node.js modules.
	// `module.createRequire()` is being used to create one that is able to
	// load files from the disk, and uses the standard CommonJS file loader
	// instead of the internal-only `require` function.
	MaybeLocal<Value> loadenv_ret = node::LoadEnvironment(
	env,
	"const publicRequire ="
	" require('node:module').createRequire(process.cwd() + '/');"
	"globalThis.require = publicRequire;"
	"require('node:vm').runInThisContext(process.argv[1]);");
	if (loadenv_ret.IsEmpty()) // There has been a JS exception.
	return 1;
	exit_code = node::SpinEventLoop(env).FromMaybe(1);
	// node::Stop() can be used to explicitly stop the event loop and keep
	// further JavaScript from running. It can be called from any thread,
	// and will act like worker.terminate() if called from another thread.
	node::Stop(env);
	}
	return exit_code;
	}

) too?

[joyeecheung]

Maybe, the code in there would continue to work, the snapshot capability and the snapshot testing code was added by #45888, so probably out of scope of this PR.

[RaisinTen]

The doc has a reference to this file in

node/doc/api/embedding.md

Line 24 in 6a489df

The full code can be found [in the Node.js source tree][embedtest.cc].

, so I thought these were supposed to be in sync but this too lgtm if that's not needed

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/53962/

[joyeecheung]

CI was green although the bot still had trouble communicating the green result back to GitHub so it got stuck as "pending. Landed it manually in cdcb01a...1995eca.