src: avoid shadowed string in fs_permission

[codebytere]

Refs #44004

Addresses the following shadowing issue in fs_permission:

../../third_party/electron_node/src/permission/fs_permission.h:34:37: error: declaration shadows a field of 'node::permission::FSPermission::RadixTree::Node' [-Werror,-Wshadow]
   34 |       Node* CreateChild(std::string prefix) {
      |                                     ^
../../third_party/electron_node/src/permission/fs_permission.h:24:19: note: previous declaration is here
   24 |       std::string prefix;
      |                   ^
1 error generated.

Allows Electron to remove a patch.

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56233/

[codebytere]

Seeing test failures that i didn't see when running Electron's version against Node.js tests - looking into it 🤔

[RafaelGSS]

@codebytere this should fix your issue:

diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h
index 4577a73c37d..642d2dbc6ea 100644
--- a/src/permission/fs_permission.h
+++ b/src/permission/fs_permission.h
@@ -43,7 +43,7 @@ class FSPermission final : public PermissionBase {

         Node* child = children[label];
         if (child == nullptr) {
-          children[label] = new Node(prefix);
+          children[label] = new Node(path_prefix);
           return children[label];
         }

[codebytere]

@RafaelGSS done, thanks!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56627/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56635/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56646/

[nodejs-github-bot]

Landed in 088f4cc