http: remove misleading warning#51204
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Dec 21, 2023
Merged
Conversation
There are cases where the `'clientError'` event can be emitted multiple times, even if the socket is correctly destroyed. Fixes: nodejs#51073
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
pimterry
reviewed
Dec 19, 2023
Member
pimterry
left a comment
pimterry
left a comment
There was a problem hiding this comment.
👍
Nice work, thanks @lpinca! I can imagine other solutions to fix this, like batching client errors, but one way or another they'd end up changing more sensitive existing behaviour elsewhere, so just dropping the incorrect warning seems much simpler.
Collaborator
lpinca
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
Sorry, I don't understand this. If we remove this, we will reopen #43548. Or am I missing anything? |
Member
Author
Contributor
|
Oh, I see. Makes sense now. Thanks! |
ShogunPanda
approved these changes
Dec 20, 2023
Collaborator
aymen94
approved these changes
Dec 21, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 30f8ef1 |
|
this is not present in latest node 18, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where the
'clientError'event can be emitted multiple times, even if the socket is correctly destroyed.Fixes: #51073