Conversation
|
Review requested:
|
|
I think the idea is to still get the test result, otherwise there are no distinction between skip and todo and we might as keep only one 🤔 |
|
Todo test should fail but not exit with code 1, not affecting the result. Making it a noop makes it just an alias of skip. |
I think running a todo test doesn't make any sense as it will fails coz it's not fully implemented or maybe planned to write it later on. One thing that we can do to make a distinction between skip and todo as to restrict user to not pass test fn when test is marked as todo (similar to jest-todo). |
+1 |
I found that |
0684d04 to
ae2a8ff
Compare
ae2a8ff to
41c6d06
Compare
marco-ippolito
left a comment
There was a problem hiding this comment.
I'm not sure the wording is right.
AFAIK the failure of a test does not terminate the execution it makes exit code 1.
Saying that todo does not terminate it imples that failure do which I dont think is correct
| test from finishing first and cancelling the subtest | ||
| as shown in the following example. | ||
|
|
||
| **Note:** Running a `todo` test does not terminate the execution of the test |
There was a problem hiding this comment.
| **Note:** Running a `todo` test does not terminate the execution of the test | |
| Running a `todo` test does not terminate the execution of the test |
|
Closing per the previous comment. |
ref: #49013 (comment)