src: address coverity warning in module_wrap.cc#52143
Closed
mhdawson wants to merge 2 commits intonodejs:mainfrom
Closed
src: address coverity warning in module_wrap.cc#52143mhdawson wants to merge 2 commits intonodejs:mainfrom
mhdawson wants to merge 2 commits intonodejs:mainfrom
Conversation
Member
mhdawson
commented
Mar 18, 2024
mhdawson
commented
- remove copying as suggested by coverity
- remove copying as suggested by coverity Signed-off-by: Michael Dawson <midawson@redhat.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
Author
|
Coverity warning: 130 if (env()->options()->warnings) {
CID 352460: (#1 of 1): AUTO_CAUSES_COPY (AUTO_CAUSES_COPY)
1. auto_causes_copy: Using the auto keyword without an & causes the copy of an object of type tuple.
Use auto & instead of auto.
131 for (auto pair : stalled) {
132 Local<v8::Message> message = std::get<1>(pair);
133
134 std::string reason = "Warning: Detected unsettled top-level await at ";
135 std::string info =
136 FormatErrorMessage(isolate, context, "", message, true);
137 reason += info;
138 FPrintF(stderr, "%s\n", reason);
139 }
140 } |
Signed-off-by: Michael Dawson <midawson@redhat.com>
legendecas
approved these changes
Mar 19, 2024
lpinca
approved these changes
Mar 19, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
mhdawson
added a commit
that referenced
this pull request
Mar 25, 2024
- remove copying as suggested by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52143 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in 681b0a3 |
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Mar 25, 2024
- remove copying as suggested by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#52143 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
- remove copying as suggested by coverity Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#52143 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
This doesn't land cleanly on v20, requires a manual backport |
marco-ippolito
added
the
backport-requested-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.