Closed
Conversation
Backport c-ares/c-ares#802 which fixes compilation error when building for Windows with UNICODE defined.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
cares
zcbenz
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Jul 4, 2024
StefanStojanovic
approved these changes
Jul 4, 2024
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
A new version of c-ares is already available. I think it is better to upgrade to that version instead of cherry picking this commit. |
Contributor
Author
|
I’m good updating to the latest version instead. |
Member
|
See #53722. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport c-ares/c-ares#802 which fixes compilation error when building for Windows with UNICODE defined.