[v22.x backport] module: add findPackageJSON util#56074
Merged
aduh95 merged 2 commits intonodejs:v22.x-stagingfrom Dec 10, 2024
Merged
[v22.x backport] module: add findPackageJSON util#56074aduh95 merged 2 commits intonodejs:v22.x-stagingfrom
findPackageJSON util#56074aduh95 merged 2 commits intonodejs:v22.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Contributor
|
Can you also backport #55543 in the same PR please? |
Member
Author
Looks like the answer is yes 🙂 |
Member
Author
Well that was easy 😁 |
aduh95
approved these changes
Nov 29, 2024
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Nov 29, 2024
Collaborator
Collaborator
Member
Author
|
It looks like everything is green but coverage, which seems bogus: it passed on the original. To my knowledge, it already has full coverage (aside from #55822), so I'm not sure how to address this. |
JakobJingleheimer
added
commit-queue
PR-URL: nodejs#55412 Backport-PR-URL: nodejs#56074 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#55543 Backport-PR-URL: nodejs#56074 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#55412
aduh95
force-pushed
the
backport/add-findPackageJSON-util
branch
from
3a67999 to
4f85047
Compare
Contributor
|
Landed in 552a182...4f85047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #55412
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com