Skip to content

module: unflag --experimental-strip-types#56350

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
marco-ippolito:unflag-strip-types
Dec 26, 2024
Merged

module: unflag --experimental-strip-types#56350
nodejs-github-bot merged 1 commit intonodejs:mainfrom
marco-ippolito:unflag-strip-types

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Dec 24, 2024 •
edited
Loading

It's time to enable it by default to catch some more bugs, currently there are no open issues.
I think it's a semver minor change.

Fixes: nodejs/typescript#17

@nodejs/tsc for visibility

Notable change section:

This change enables the flag --experimental-strip-types by default.
Node.js will be able to execute TypeScript files without additional configuration. Note that there are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 24, 2024

Review requested:

  • @nodejs/loaders
  • @nodejs/performance
  • @nodejs/test_runner
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 24, 2024
@marco-ippolito marco-ippolito added strip-types Issues or PRs related to strip-types support blocked PRs that are blocked by other issues or PRs. wip Issues and PRs that are still a work in progress. labels Dec 24, 2024
@marco-ippolito marco-ippolito marked this pull request as ready for review December 24, 2024 18:17
@marco-ippolito marco-ippolito removed wip Issues and PRs that are still a work in progress. blocked PRs that are blocked by other issues or PRs. labels Dec 24, 2024
@codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (da3f388) to head (d847c32).
Report is 1407 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56350      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         657      657              
  Lines      190655   190658       +3     
  Branches    36582    36584       +2     
==========================================
- Hits       168824   168820       -4     
- Misses      15008    15011       +3     
- Partials     6823     6827       +4
Files with missing lines Coverage Δ
src/node_options.cc 87.92% <ø> (ø)
src/node_options.h 98.30% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Dec 25, 2024
mcollina
mcollina approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. notable-change PRs with changes that should be highlighted in changelogs. baking-for-lts PRs that need to wait before landing in a LTS release. labels Dec 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@marco-ippolito marco-ippolito added the module Issues and PRs related to the module subsystem. label Dec 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 25, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/64202/

bmuenzenmeyer
bmuenzenmeyer reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excited for this, having watched it's development and played with it quite a bit.
some suggestions and questions, none blocking

aduh95
aduh95 reviewed Dec 25, 2024
View reviewed changes
@anonrig
Copy link
Member

anonrig commented Dec 26, 2024

What about process.features.typescript? Does that also needs changing?

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Dec 26, 2024

What about process.features.typescript? Does that also needs changing?

It works fine, tests are updated (now the default value is 'strip')

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2024
marco-ippolito added a commit that referenced this pull request Jul 4, 2025
@marco-ippolito
deps: update amaro to 0.5.1
ef90a39 
PR-URL: #57704
Backport-PR-URL: #57298
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
marco-ippolito pushed a commit that referenced this pull request Jul 4, 2025
@nodejs-github-bot @marco-ippolito
deps: update amaro to 0.5.2
9e21f82 
PR-URL: #57871
Backport-PR-URL: #57298
Fixes: #57471
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
marco-ippolito pushed a commit that referenced this pull request Jul 4, 2025
@nodejs-github-bot @marco-ippolito
deps: update amaro to 0.5.3
b9ef31f 
PR-URL: #58174
Backport-PR-URL: #57298
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #56350
Fixes: nodejs/typescript#17
marco-ippolito pushed a commit that referenced this pull request Jul 4, 2025
@nodejs-github-bot @marco-ippolito
deps: update amaro to 1.0.0
257ea34 
PR-URL: #58639
Backport-PR-URL: #57298
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
marco-ippolito pushed a commit that referenced this pull request Jul 4, 2025
@nodejs-github-bot @marco-ippolito
deps: update amaro to 1.1.0
4af5915 
PR-URL: #58754
Backport-PR-URL: #57298
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
@marco-ippolito marco-ippolito added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Jul 4, 2025
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@marco-ippolito @RafaelGSS
module: unflag --experimental-strip-types
8d1f5df 
PR-URL: #56350
Backport-PR-URL: #57298
Fixes: nodejs/typescript#17
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@aduh95 @RafaelGSS
doc: add history entries to --input-type section
354a68c 
PR-URL: #58175
Backport-PR-URL: #57298
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@marco-ippolito @RafaelGSS
module: refactor commonjs typescript loader
c07745a 
This commit refactors the CommonJS loader to remove TypeScript-specific
extensions from the require.extensions object for compatibility with
libraries that depended on it to initialize extenal TypeScript loaders.

PR-URL: #58657
Backport-PR-URL: #57298
Refs: nodejs/typescript#37
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@marco-ippolito @RafaelGSS
module: remove experimental warning from type stripping
c898491 
PR-URL: #58643
Backport-PR-URL: #57298
Refs: nodejs/typescript#24
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@marco-ippolito @RafaelGSS
module: improve typescript error message format
fe7994e 
PR-URL: #57687
Backport-PR-URL: #57298
Fixes: #56830
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.5.0
25f8682 
PR-URL: #57687
Backport-PR-URL: #57298
Fixes: #56830
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@marco-ippolito @RafaelGSS
deps: update amaro to 0.5.1
81a10a6 
PR-URL: #57704
Backport-PR-URL: #57298
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.5.2
7fcf675 
PR-URL: #57871
Backport-PR-URL: #57298
Fixes: #57471
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@nodejs-github-bot @RafaelGSS
deps: update amaro to 0.5.3
258534d 
PR-URL: #58174
Backport-PR-URL: #57298
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@nodejs-github-bot @RafaelGSS
deps: update amaro to 1.0.0
752dde1 
PR-URL: #58639
Backport-PR-URL: #57298
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
@nodejs-github-bot @RafaelGSS
deps: update amaro to 1.1.0
26f3711 
PR-URL: #58754
Backport-PR-URL: #57298
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #56350
Fixes: nodejs/typescript#17
aduh95 added a commit that referenced this pull request Jul 21, 2025
@aduh95
doc: add history entry for TS support in hooks
eeb8168 
PR-URL: #58732
Refs: #56350
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit that referenced this pull request Jul 24, 2025
@aduh95
doc: add history entry for TS support in hooks
bbe4ad7 
PR-URL: #58732
Refs: #56350
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
nodejs-github-bot added a commit that referenced this pull request Jul 28, 2025
@nodejs-github-bot
2025-07-29, Version 22.18.0 'Jod' (LTS)
2ca0c42 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
  * (SEMVER-MINOR) update amaro to 1.0.0 (Node.js GitHub Bot) #56350
  * (SEMVER-MINOR) update amaro to 0.5.3 (Node.js GitHub Bot) #56350
  * (SEMVER-MINOR) update amaro to 0.5.2 (Node.js GitHub Bot) #56350
  * (SEMVER-MINOR) update amaro to 0.5.1 (Marco Ippolito) #56350
  * (SEMVER-MINOR) update amaro to 0.5.0 (nodejs-github-bot) #56350
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
  * add islandryu to collaborators (Shima Ryuhei) #58714
  * (SEMVER-MINOR) add history entries to `--input-type` section (Antoine du Hamel) #56350
esm:
  * (SEMVER-MINOR) implement import.meta.main (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) improve typescript error message format (Marco Ippolito) #56350
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) refactor commonjs typescript loader (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
test:
  * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385
url:
  * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385

PR-URL: #59256
aduh95 added a commit that referenced this pull request Jul 28, 2025
@nodejs-github-bot @aduh95
2025-07-29, Version 22.18.0 'Jod' (LTS)
4c1b52e 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Jul 31, 2025
@nodejs-github-bot @aduh95
2025-07-31, Version 22.18.0 'Jod' (LTS)
c9ff1ae 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Jul 31, 2025
@nodejs-github-bot @aduh95
2025-07-31, Version 22.18.0 'Jod' (LTS)
5acb923 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
meteorqz6 pushed a commit to meteorqz6/node that referenced this pull request Aug 2, 2025
@nodejs-github-bot @aduh95 @meteorqz6
2025-07-31, Version 22.18.0 'Jod' (LTS)
42af315 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
karfau
karfau reviewed Aug 4, 2025
View reviewed changes
doc/api/cli.md
### `--no-experimental-strip-types`

<!-- YAML
added: v22.6.0
Copy link

@karfau karfau Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy paste error, right?
This toggle was added in v22.18.0 according to https://github.com/nodejs/node/blob/5bea645e4b1ff9b740acf24cfb899fb099ba1065/doc/changelogs/CHANGELOG_V22.md#2025-07-31-version-22180-jod-lts-aduh95
and --experimental-strip-types was dropped without replacement as part of that version.

Copy link
Member Author

@marco-ippolito marco-ippolito Aug 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v22.6.0 the flag was introduced, in v22.18.0 is enabled by default. --no-experimental-strip-types has been available since then

Copy link

@karfau karfau Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--experimental-strip-types was introduced in 22.6, and --no-experimental-strip-types was introduced in 22.18, or are they the same flag and one is the negation of the other?

Copy link
Contributor

@aduh95 aduh95 Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They the same flag, one is the negation of the other, both were introduced in 22.6.0 (we only list the non-default one in this document)

panva pushed a commit to panva/node that referenced this pull request Aug 7, 2025
@nodejs-github-bot @aduh95 @panva
2025-07-31, Version 22.18.0 'Jod' (LTS)
1ea72c3 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
mete0rfish pushed a commit to mete0rfish/node-contribute that referenced this pull request Aug 9, 2025
@nodejs-github-bot @aduh95 @mete0rfish
2025-07-31, Version 22.18.0 'Jod' (LTS)
159aa69 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva pushed a commit to panva/node that referenced this pull request Aug 9, 2025
@nodejs-github-bot @aduh95 @panva
2025-07-31, Version 22.18.0 'Jod' (LTS)
950703d 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth left review comments

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@pmarchini pmarchini pmarchini approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

+1 more reviewer

@karfau karfau karfau left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. baking-for-lts PRs that need to wait before landing in a LTS release. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. strip-types Issues or PRs related to strip-types support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unflag --experimental-strip-types