src: improve thread safety of `TaskQueue` by codebytere · Pull Request #57910 · nodejs/node

codebytere · 2025-04-17T12:47:23Z

Improve thread safety of TaskQueue by making locking of TaskQueue explicit and thus hopefully preventing a crash due to uv_async_send being called with nullptr.

codecov · 2025-04-17T13:40:02Z

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.26%. Comparing base (5077ea4) to head (d71a542).
Report is 425 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_platform.cc	97.53%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #57910    +/-   ##
========================================
  Coverage   90.25%   90.26%            
========================================
  Files         630      630            
  Lines      185691   186170   +479     
  Branches    36407    36480    +73     
========================================
+ Hits       167589   168039   +450     
+ Misses      10994    10975    -19     
- Partials     7108     7156    +48

Files with missing lines	Coverage Δ
src/node_platform.h	`80.00% <100.00%> (+5.00%)`	⬆️
src/node_platform.cc	`88.70% <97.53%> (+0.83%)`	⬆️

... and 65 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/node_platform.h

src/node_platform.cc

mcollina · 2025-04-18T07:39:42Z

@codebytere I wonder if this could also help with #54918.

bnoordhuis

LGTM with some suggestions.

src/node_platform.cc

mcollina

RSLGTM

nodejs-github-bot · 2025-04-19T13:54:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66364/

lpinca · 2025-04-19T14:42:35Z

@codebytere I wonder if this could also help with #54918

I applied this patch and unfortunately it does not.

mcollina · 2025-04-19T15:00:27Z

Thanks for checking!

nodejs-github-bot · 2025-04-21T07:44:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66399/

joyeecheung

LGTM (as in, my tiny head can't find potential issues out of the new locks), though I think it can use a bit more comments (I am fairly certain that the race can only happen at shutdown, the platform is initialized too early for any tasks to be posted during that process)

src/node_platform.cc

PR-URL: #57910 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs/node#57910

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57910

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

marco-ippolito · 2025-06-05T09:17:16Z

This commit requires a manual backport to land on v20.x

nodejs/node#57910

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 * chore: fix out of date patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere requested review from bnoordhuis and joyeecheung April 17, 2025 12:47

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 17, 2025

codebytere force-pushed the mutex-flush-tasks branch from cfdeed7 to 6b85518 Compare April 17, 2025 12:50

bnoordhuis reviewed Apr 17, 2025

View reviewed changes

src/node_platform.h Outdated Show resolved Hide resolved

src/node_platform.h Outdated Show resolved Hide resolved

src/node_platform.cc Outdated Show resolved Hide resolved

src/node_platform.cc Show resolved Hide resolved

codebytere force-pushed the mutex-flush-tasks branch 2 times, most recently from 0ffd2a4 to f1b6765 Compare April 17, 2025 17:47

codebytere requested a review from bnoordhuis April 18, 2025 08:53

codebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 18, 2025

nodejs deleted a comment from github-actions bot Apr 18, 2025

codebytere removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 18, 2025

bnoordhuis approved these changes Apr 18, 2025

View reviewed changes

src/node_platform.cc Outdated Show resolved Hide resolved

src/node_platform.cc Outdated Show resolved Hide resolved

src/node_platform.cc Show resolved Hide resolved

codebytere force-pushed the mutex-flush-tasks branch 2 times, most recently from 0192c4f to 78a514e Compare April 19, 2025 10:42

mcollina approved these changes Apr 19, 2025

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025

jasnell approved these changes Apr 19, 2025

View reviewed changes

joyeecheung approved these changes Apr 21, 2025

View reviewed changes

src/node_platform.cc Show resolved Hide resolved

src: improve thread safety of TaskQueue

d71a542

codebytere force-pushed the mutex-flush-tasks branch from 78a514e to d71a542 Compare April 21, 2025 17:50

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

codebytere added a commit to electron/electron that referenced this pull request May 23, 2025

src: improve thread safety of TaskQueue

f48e9dd

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request May 26, 2025

src: improve thread safety of TaskQueue

9669a2f

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request May 29, 2025

src: improve thread safety of TaskQueue

66bfa7f

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 2, 2025

src: improve thread safety of TaskQueue

db53485

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: improve thread safety of TaskQueue

165720e

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: improve thread safety of TaskQueue

cb29c36

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: improve thread safety of TaskQueue

ffcc638

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: improve thread safety of TaskQueue

e405541

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: improve thread safety of TaskQueue

1c5ec83

nodejs/node#57910

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: improve thread safety of TaskQueue

c1b9251

nodejs/node#57910

VlkrS mentioned this pull request Jun 3, 2025

node 22.16.0 on OpenBSD: building a module with node-gyp spins in a tight loop #58569

Closed

marco-ippolito added backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Jun 5, 2025

codebytere added a commit to electron/electron that referenced this pull request Jun 6, 2025

src: improve thread safety of TaskQueue

1cddc3c

nodejs/node#57910

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

hhugo mentioned this pull request Jun 13, 2025

uv_async_send() inconsistency libuv/libuv#3622

Open

codebytere added a commit to electron/electron that referenced this pull request Jun 18, 2025

src: improve thread safety of TaskQueue

f20bd09

nodejs/node#57910

richardlau mentioned this pull request Dec 1, 2025

Segmentation Faults on node 20.19.6 #60882

Open

Uh oh!

Conversation

codebytere commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina commented Apr 18, 2025

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 19, 2025

Uh oh!

lpinca commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina commented Apr 19, 2025

Uh oh!

nodejs-github-bot commented Apr 21, 2025

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marco-ippolito commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codebytere commented Apr 17, 2025 •

edited

Loading

codecov bot commented Apr 17, 2025 •

edited

Loading

lpinca commented Apr 19, 2025 •

edited

Loading