Improve util getCallSites by iwuliz · Pull Request #57948 · nodejs/node

iwuliz · 2025-04-20T14:39:22Z

This patch has two commits:

Renamed test/fixtures/typescript/ts/test-get-callsite.ts and test/fixtures/typescript/ts/test-get-callsite-explicit.ts to test/fixtures/typescript/ts/test-get-callsites.ts and test/fixtures/typescript/ts/test-get-callsites-explicit.ts respectively, and update relevant occurrence, since the function getCallSite was renamed to getCallSites.
Changed DCHECK TO CHECK to make the validation more robust.

nodejs-github-bot · 2025-04-20T14:39:27Z

Review requested:

@nodejs/typescript

codecov · 2025-04-20T15:28:09Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.27%. Comparing base (7102ea1) to head (ba6676c).
Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_util.cc	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57948      +/-   ##
==========================================
- Coverage   90.27%   90.27%   -0.01%     
==========================================
  Files         630      630              
  Lines      186115   186116       +1     
  Branches    36467    36465       -2     
==========================================
- Hits       168010   168009       -1     
+ Misses      10973    10969       -4     
- Partials     7132     7138       +6

Files with missing lines	Coverage Δ
src/node_util.cc	`81.79% <0.00%> (-0.26%)`	⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-04-21T01:53:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66392/

nodejs-github-bot · 2025-04-22T14:45:51Z

Landed in 6bf7fd7...367d593

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

iwuliz added 2 commits April 20, 2025 23:50

test: rename to getCallSites

33c627b

src: change DCHECK to CHECK

ba6676c

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 20, 2025

marco-ippolito approved these changes Apr 20, 2025

View reviewed changes

jakecastelli approved these changes Apr 21, 2025

View reviewed changes

jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2025

lpinca approved these changes Apr 21, 2025

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 22, 2025

nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2025

test: rename to getCallSites

fba9c27

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2025

src: change DCHECK to CHECK

367d593

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot closed this Apr 22, 2025

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

test: rename to getCallSites

e2446ac

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

src: change DCHECK to CHECK

2216371

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

test: rename to getCallSites

21d052a

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

src: change DCHECK to CHECK

46062f1

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

test: rename to getCallSites

062276f

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

src: change DCHECK to CHECK

a1935ba

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

test: rename to getCallSites

615055a

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

src: change DCHECK to CHECK

4fb4c18

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

test: rename to getCallSites

8d0c061

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

src: change DCHECK to CHECK

dfca085

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

test: rename to getCallSites

2e6e62b

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

src: change DCHECK to CHECK

4338e90

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

test: rename to getCallSites

d8847d9

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

src: change DCHECK to CHECK

60d7f1c

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

test: rename to getCallSites

265a450

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

src: change DCHECK to CHECK

f123439

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

test: rename to getCallSites

6fa7144

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

src: change DCHECK to CHECK

5f25d3d

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

test: rename to getCallSites

b7995e8

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

src: change DCHECK to CHECK

0eced6d

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

github-actions bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

test: rename to getCallSites

13f8f9c

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 pushed a commit that referenced this pull request May 19, 2025

src: change DCHECK to CHECK

32b6e70

PR-URL: #57948 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve util getCallSites#57948

Improve util getCallSites#57948
iwuliz wants to merge 2 commits intonodejs:mainfrom
iwuliz:improve-util-get-callsites

iwuliz commented Apr 20, 2025

Uh oh!

nodejs-github-bot commented Apr 20, 2025

Uh oh!

codecov bot commented Apr 20, 2025 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 21, 2025

Uh oh!

nodejs-github-bot commented Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

iwuliz commented Apr 20, 2025

Uh oh!

nodejs-github-bot commented Apr 20, 2025

Uh oh!

codecov bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 21, 2025

Uh oh!

nodejs-github-bot commented Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Apr 20, 2025 •

edited

Loading