assert: change utils to use index instead of for...of

[JinhyeokFang]

This PR changes a for...of loop to an index-based for loop in the getErrMessage() function within lib/internal/assert/utils.js.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68308/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.90%. Comparing base (53c0897) to head (3396883).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59278      +/-   ##
==========================================
+ Coverage   89.36%   89.90%   +0.53%     
==========================================
  Files         654      655       +1     
  Lines      192554   192829     +275     
  Branches    37436    37793     +357     
==========================================
+ Hits       172073   173356    +1283     
+ Misses      13007    12037     -970     
+ Partials     7474     7436      -38     

Files with missing lines	Coverage Δ
lib/internal/assert/utils.js	92.11% <100.00%> (+1.10%)	⬆️

... and 123 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68364/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68398/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59278
✔  Done loading data for nodejs/node/pull/59278
----------------------------------- PR info ------------------------------------
Title      assert: change utils to use index instead of for...of (#59278)
Author     방진혁 <jinhyeokfang@gmail.com> (@JinhyeokFang, first-time contributor)
Branch     JinhyeokFang:assert -> nodejs:main
Labels     assert, author ready, needs-ci, commit-queue-squash
Commits    2
 - assert: change utils to use index instead of for...of
 - Merge branch 'nodejs:main' into assert
Committers 2
 - 방진혁 <jinhyeokfang@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/59278
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59278
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 29 Jul 2025 22:39:39 GMT
   ✔  Approvals: 3
   ✔  - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/59278#pullrequestreview-3069397440
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/59278#pullrequestreview-3069449814
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/59278#pullrequestreview-3082422895
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-08-04T09:42:58Z: https://ci.nodejs.org/job/node-test-pull-request/68398/
- Querying data for job/node-test-pull-request/68398/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   5bea645e4b..f7c2a7ed4a  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 1b1c4fda34 http: add server.keepAliveTimeoutBuffer option
 - f7c2a7ed4a http: add server.keepAliveTimeoutBuffer option
--------------------------------------------------------------------------------
HEAD is now at f7c2a7ed4a http: add server.keepAliveTimeoutBuffer option
   ✔  Reset to origin/main
- Downloading patch for 59278
From https://github.com/nodejs/node
 * branch                  refs/pull/59278/merge -> FETCH_HEAD
✔  Fetched commits as f7c2a7ed4a88..2398f168424b
--------------------------------------------------------------------------------
error: commit 2398f168424b7bb210cfb8f73bce997617b2073f is a merge but no -m option was given.
fatal: cherry-pick failed
[main 6f69837b78] assert: change utils to use index instead of for...of
 Author: 방진혁 <jinhyeokfang@gmail.com>
 Date: Tue Jul 29 21:23:26 2025 +0900
 1 file changed, 2 insertions(+), 1 deletion(-)
   ✘  Failed to apply patches

https://github.com/nodejs/node/actions/runs/16724914619

[daeyeon]

There's a merge conflict that needs resolving. Please rebase onto the latest main and resolve the conflict so we can proceed.

[JinhyeokFang]

@daeyeon Thank you for the notice. I have now rebased the branch on the latest main to resolve the merge conflict. Could you please add it back to the commit queue when you get a chance?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68408/

[JinhyeokFang]

The CI failure on Coverage Windows should be fixed in #59381. Could you please trigger the CI again?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68457/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68463/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68464/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68477/

[nodejs-github-bot]

Landed in f3adc11