-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
src: fix --build-sea default executable path
#61708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
|
Just compiled it and it runs as expected |
|
Thanks for the PR, can you add a test? I think you may need to use child_process.execSync and tweak the path variables a bit to reproduce it with a shell. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61708 +/- ##
==========================================
- Coverage 89.75% 89.75% -0.01%
==========================================
Files 674 675 +1
Lines 204416 204502 +86
Branches 39285 39308 +23
==========================================
+ Hits 183472 183541 +69
- Misses 13227 13241 +14
- Partials 7717 7720 +3
🚀 New features to boost your workflow:
|
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
|
The only test failure is the same test failing in |
|
Landed in 30adc7c |
Fixes #61579