zlib: add support for brotli compression dictionary #61763
+168
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds JS API support for custom compression dictionaries with Brotli in the zlib library. The underlying Brotli dependency already supports this and zstd exposes something similar. This follows the zstd approach for using a custom dictionary but for Brotli. Fixes: nodejs#52250
nodejs-github-bot
added
c++
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
addaleax
removed
the
author ready
addaleax
reviewed
Feb 11, 2026
| void Close(); | ||
| void DoThreadPoolWork(); | ||
| CompressionError Init(); | ||
| CompressionError Init(std::string_view dictionary = {}); |
Member
There was a problem hiding this comment.
This didn't feel important enough to request an update, but since the linter is failing anyway – if this were
Suggested change
| CompressionError Init(std::string_view dictionary = {}); | |
| CompressionError Init(std::vector<uint8_t>&& dictionary = {}); |
the ownership semantics would be a bit clearer (i.e. it becomes obvious that this class will take ownership of the argument, instead of the std::string_view case where that's less clear)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61763 +/- ##
==========================================
- Coverage 89.74% 89.72% -0.02%
==========================================
Files 675 675
Lines 204642 204690 +48
Branches 39322 39330 +8
==========================================
+ Hits 183657 183668 +11
- Misses 13257 13289 +32
- Partials 7728 7733 +5
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds JS API support for custom compression dictionaries with Brotli in the zlib library. The underlying Brotli dependency already supports this and zstd exposes something similar. This follows the zstd approach for using a custom dictionary but for Brotli.
Fixes: #52250
Notes
I wanted to get the change up here first to get feedback and ensure the API makes sense. I can then update any relevant docs. The tests