fs: create callback before nullCheck call#7167
Closed
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Closed
fs: create callback before nullCheck call#7167thefourtheye wants to merge 1 commit intonodejs:masterfrom
thefourtheye wants to merge 1 commit intonodejs:masterfrom
Conversation
The callback function creation should happen before the `nullCheck`, because it might invoke the callback to indicate errors.
thefourtheye
added
the
fs
Contributor
Author
|
|
||
| assert.throws(function() { | ||
| fs.access(__filename, fs.F_OK, {}); | ||
| }, /"callback" argument must be a function/); |
Member
There was a problem hiding this comment.
I don't think this behavior should change. Calling fs.access() without a callback arguably never makes sense.
Member
|
This change is not really necessary. |
Contributor
Author
|
@bnoordhuis Correct. This change will not do any good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
fs
Description of change
The callback function creation should happen before the
nullCheck,because it might invoke the callback to indicate errors.
This was pointed out by @cjihrig, in #7068 (comment)
cc @nodejs/fs