Closed
Conversation
tools/test.py
Outdated
Member
There was a problem hiding this comment.
This function is basically dead code. I'd be alright with removing it and the code path leading up to it (the if not options.no_build: statement in Main().)
Member
|
LGTM with CI and with or without @bnoordhuis’ suggestion |
As the `no-build` and `build-only` options are not used anymore, they can be safely removed.
The format specifier is incomplete and without this the program will fail at runtime, with "incomplete format" error.
thefourtheye
force-pushed
the
fix-py-errors
branch
from
75ee865 to
6060be1
Compare
Contributor
Author
|
@bnoordhuis I removed the |
Member
|
LGTM |
Contributor
Author
thefourtheye
added a commit
that referenced
this pull request
Jul 12, 2016
As the `no-build` and `build-only` options are not used anymore, they can be safely removed. PR-URL: #7620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
thefourtheye
added a commit
that referenced
this pull request
Jul 12, 2016
The format specifier is incomplete and without this the program will fail at runtime, with "incomplete format" error. PR-URL: #7620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
pushed a commit
that referenced
this pull request
Jul 15, 2016
As the `no-build` and `build-only` options are not used anymore, they can be safely removed. PR-URL: #7620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
pushed a commit
that referenced
this pull request
Jul 15, 2016
The format specifier is incomplete and without this the program will fail at runtime, with "incomplete format" error. PR-URL: #7620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
|
||
| if not os.path.isdir(options.icusrc): | ||
| print 'Missing source ICU dir --icusrc=%' % (options.icusrc) | ||
| print 'Missing source ICU dir --icusrc=%s' % (options.icusrc) |
Contributor
|
@thefourtheye setting as don't land on v4.x please feel free to send backport if it should be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
There are two fixes.
RunProcessfunction returns four values, but it is unpacked overthree variables and this will fail at runtime. This patch unpacks the
fourth value on a dummy variable. -
tools/test.pyfail at runtime, with "incomplete format" error. -
tools/icu/shrink-icu-src.pycc @bnoordhuis @addaleax @jasnell