Closed
Conversation
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.
Trott
added
zlib
Member
Author
Member
|
CI is green, LGTM |
| { | ||
| const deflateRaw = zlib.createDeflateRaw(); | ||
| assert(deflateRaw instanceof zlib.DeflateRaw); | ||
| } |
Member
Author
There was a problem hiding this comment.
You mean the scoping braces? No, not strictly necessary, but desirable IMO. Having every test in its own scope means (among other benefits) that you can freely add and remove variables in one test without worrying about side effects in any of the other tests. Right now, there's only two tests in this file but ideally more tests will be added over time.
Member
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 31, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: nodejs#8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in f6e33ef |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: nodejs#8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: #8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: #8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: #8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: #8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Currently, there are no tests that exercise `zlib.createInflateRaw()` or `zlib.createDeflateRaw()`. This adds minimal tests that invoke the functions and confirm that they return `zlib.InflateRaw`/`zlib.DeflateRaw` objects. PR-URL: #8306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test zlib
Description of change
Currently, there are no tests that exercise
zlib.createInflateRaw()orzlib.createDeflateRaw().This adds minimal tests that invoke the functions and confirm that they
return
zlib.InflateRaw/zlib.DeflateRawobjects.