inspector,test: zero out expectations#8985
Closed
joaocgreis wants to merge 2 commits intonodejs:v6.x-stagingfrom
Closed
inspector,test: zero out expectations#8985joaocgreis wants to merge 2 commits intonodejs:v6.x-stagingfrom
joaocgreis wants to merge 2 commits intonodejs:v6.x-stagingfrom
Conversation
Visual Studio 2013 does not zero out the structure when allocating.
joaocgreis
added
c++
bnoordhuis
approved these changes
Oct 10, 2016
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
But can you add an explaining comment?
Member
Author
|
Thanks, updated. |
Contributor
|
LGTM. Thanks! |
Member
Author
|
#7989 resolved, no need to land this. Still, thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Inspector (test)
Description of change
VS2013 was not running in CI for v6 when #8832 landed. When compiling with VS2013 and running on Windows 2008,
cctest.exehangs consuming 100% CPU. This happens because Visual Studio 2013 does not zero out theexpectationsstructure when allocating.@nodejs/release this only needs to land if #7989 is not approved before the next v6 release.
CI: https://ci.nodejs.org/view/All/job/node-test-commit/5512/
cc @nodejs/v8-inspector