test: replace var with const in test-require-dot#9916
Closed
amarzavery wants to merge 2 commits intonodejs:masterfrom
Closed
test: replace var with const in test-require-dot#9916amarzavery wants to merge 2 commits intonodejs:masterfrom
amarzavery wants to merge 2 commits intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Dec 1, 2016
Contributor
Author
|
closed #9896 as the commit message was not following the guidelines and git commit --amend resulted into 3 commits. |
| var module = require('module'); | ||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const m = require('module'); |
Contributor
There was a problem hiding this comment.
why not keeping module as it is?
Contributor
Author
There was a problem hiding this comment.
keeping the module as it is causes an error, hence renaming it something else:
/Users/amarz/summit16/node/test/parallel/test-require-dot.js:4
const module = require('module');
^
SyntaxError: Identifier 'module' has already been declared
imyller
added
code-and-learn
not-an-aardvark
approved these changes
Dec 1, 2016
gibfahn
approved these changes
Dec 2, 2016
Member
gibfahn
left a comment
gibfahn
left a comment
There was a problem hiding this comment.
LGTM if CI is happy.
FYI, the extra commits possibly came from doing a git pull.
lpinca
reviewed
Dec 5, 2016
test/parallel/test-require-dot.js
Outdated
| const c = require('.'); | ||
|
|
||
| assert.equal(c.value, 42, 'require(".") should honor NODE_PATH'); | ||
| assert.strictEqual(c.value, 42, 'require(".") should honor NODE_PATH'); No newline at end of file |
Member
There was a problem hiding this comment.
Nit: can you please add a final new line.
Contributor
jasnell
approved these changes
Dec 5, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM once the lint errors have been fixed.
Member
|
Pushed a commit that added a new line char to satisfy the linter. |
italoacasas
approved these changes
Dec 12, 2016
|
Landed fa4f158 Thanks for the contribution. |
italoacasas
pushed a commit
that referenced
this pull request
Dec 12, 2016
PR-URL: #9916 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
PR-URL: #9916 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
PR-URL: #9916 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
PR-URL: #9916 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
test: replace
varwithconstin test-require-dot