This repository was archived by the owner on Mar 22, 2023. It is now read-only.
Merged
Conversation
outsideris
reviewed
Nov 15, 2017
| - **openssl**: | ||
| - OpenSSL 소스를 1.0.2m으로 업그레이드했습니다. (Shigeki Ohtsu) [#16691](https://github.com/nodejs/node/pull/16691) | ||
| - ***복구*** "**https**: | ||
| - 내부적으로 사용하던 http를 리팩토링" (Myles Borins) [#16660](https://github.com/nodejs/node/pull/16660) |
Contributor
There was a problem hiding this comment.
nodejs/node#16660 의 제목에서 복사하면서 마지막에 쌍따옴표가 들어간거 같습니다. 저희는 빼도 될것 같습니다.
Contributor
Author
There was a problem hiding this comment.
"https:
- 내부적으로 사용하던 http를 리팩토링"
저도 처음엔 잘못 들어간건가 했는데 되돌렸던 커밋의 제목을 따옴표로 인용한 듯 보이더군요.
yous
reviewed
Nov 19, 2017
| - **openssl**: | ||
| - OpenSSL 소스를 1.0.2m으로 업그레이드했습니다. (Shigeki Ohtsu) [#16691](https://github.com/nodejs/node/pull/16691) | ||
| - ***복구*** "**https**: | ||
| - 내부적으로 사용하던 http를 리팩토링" (Myles Borins) [#16660](https://github.com/nodejs/node/pull/16660) |
Contributor
There was a problem hiding this comment.
내부적으로 사용하던 http라기보다는 http의 내부 모듈을 직접 require해서 쓰고 있었네요.
https://github.com/nodejs/node/pull/16660/files
yous
approved these changes
Nov 30, 2017
outsideris
approved these changes
Dec 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #638