Remove htmllint.#2622
Merged
Trott merged 4 commits intonodejs:masterfrom Oct 10, 2019
XhmikosR:master-xmr-rm-htmllint
Merged
Conversation
It's not a proper HTML validator and also has trouble with handlebars templates.
Aissaoui-Ahmed
approved these changes
Oct 9, 2019
This was referenced Nov 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not a proper HTML validator and also has trouble with handlebars templates.
After #2469 we'll have proper HTML validation in place.
If anyone is aware of another tool that works better for handlebars style checking, then we should use that instead. htmllint hasn't caught indentation issues (see #2483 for example), nor trailing spaces (#2387), so TBH I personally don't see any value in using it as it is now.